gnuhpc commented on PR #631: URL: https://github.com/apache/fluss-rust/pull/631#issuecomment-4754089281
Rebased onto updated #630 and applied the same `proto::*`/`Default` cleanup the maintainer requested on #629 (https://github.com/apache/fluss-rust/pull/629#pullrequestreview-4533670812) to every signature this PR adds. **All 21 admin methods that previously leaked `proto::Pb*` in args or returns now take/return domain types.** `use crate::proto;` is gone from `admin.rs`; only the pre-existing `use crate::proto::GetTableInfoResponse;` (from `main`) remains. **Response-side domain types added** under `crates/fluss/src/metadata/`: - `cluster_health.rs` — `ClusterHealth` - `kv_snapshot.rs` — `KvSnapshot`, `LatestKvSnapshots`, `RemotePathAndLocalFile`, `KvSnapshotMetadata`, `AcquireKvSnapshotLeaseResult`, `ActiveKvSnapshots` - `lake_snapshot.rs` — `LakeBucketSnapshot`, `LakeSnapshotInfo` (distinct from the existing `LakeSnapshot` used by `get_latest_lake_snapshot`) - `rebalance.rs` — `RebalanceProgress`, `TableRebalanceProgress`, `BucketRebalanceProgress`, `BucketRebalancePlan` - `remote_log.rs` — `RemoteLogManifestEntry` - Extended `config.rs` (`DescribeConfig`), `database.rs` (`DatabaseSummary`), `table_stats.rs` (`BucketStats`/`TableStats`/`BucketStatsError`), `acl.rs` (`CreateAclResult`/`DropAclsFilterResult`/`DropAclMatchingAcl`), `producer_offsets.rs` (`ProducerOffsets`) For trivially-shaped responses (single field), methods now return the primitive directly instead of wrapping — e.g. `rebalance` returns `String` (the rebalance id), `register_producer_offsets` returns `Option<i32>`, `list_acls` returns `Vec<AclInfo>`, `list_remote_log_manifests` returns `Vec<RemoteLogManifestEntry>`. **`alter_table` parameter fix** (same drop-silently-features class as `target_columns` in #629): previously took only `config_changes` + `add_columns` and hardcoded `vec![],vec![],vec![]` for drop/rename/modify columns. Now takes an `AlterTableChanges` bundle struct (avoids `clippy::too_many_arguments`) exposing all 5 change types, plus `ignore_if_not_exists` is now a parameter instead of hardcoded `false`. **`#[derive(Default)]`** not present anywhere in this PR (admin.rs has none); the wrappers consumed are already cleaned up on #629/#630. cargo build + clippy (`-D warnings`) + 556 unit tests pass locally. Pushed `29a4d0b`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
