leekeiabstraction commented on code in PR #611:
URL: https://github.com/apache/fluss-rust/pull/611#discussion_r3448191559


##########
bindings/cpp/src/lib.rs:
##########
@@ -17,17 +17,20 @@
 
 mod types;
 
+use std::collections::HashMap;

Review Comment:
   Out of scope for this PR: I'm finding that this file has grown quite big and 
also some implementation verbose (e.g. could be simplified with macro) for 
effective human review. Do you think that this would benefit from being broken 
up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to