leekeiabstraction commented on code in PR #634:
URL: https://github.com/apache/fluss-rust/pull/634#discussion_r3448244480
##########
crates/fluss/src/client/metadata.rs:
##########
@@ -344,27 +391,52 @@ mod tests {
#[test]
fn parse_bootstrap_variants() {
// valid IP
- let addr = Metadata::parse_bootstrap("127.0.0.1:8080").unwrap();
- assert_eq!(addr.port(), 8080);
+ let addrs =
Metadata::parse_bootstrap_servers("127.0.0.1:8080").unwrap();
+ assert_eq!(addrs.len(), 1);
+ assert_eq!(addrs[0].port(), 8080);
// valid hostname
- let addr = Metadata::parse_bootstrap("localhost:9090").unwrap();
- assert_eq!(addr.port(), 9090);
+ let addrs =
Metadata::parse_bootstrap_servers("localhost:9090").unwrap();
+ assert_eq!(addrs.len(), 1);
+ assert_eq!(addrs[0].port(), 9090);
// valid IPv6 address
- let addr = Metadata::parse_bootstrap("[::1]:8080").unwrap();
- assert_eq!(addr.port(), 8080);
+ let addrs = Metadata::parse_bootstrap_servers("[::1]:8080").unwrap();
+ assert_eq!(addrs.len(), 1);
+ assert_eq!(addrs[0].port(), 8080);
// invalid input: missing port
- assert!(Metadata::parse_bootstrap("localhost").is_err());
+ assert!(Metadata::parse_bootstrap_servers("localhost").is_err());
// invalid input: out-of-range port
- assert!(Metadata::parse_bootstrap("localhost:99999").is_err());
+ assert!(Metadata::parse_bootstrap_servers("localhost:99999").is_err());
// invalid input: empty string
- assert!(Metadata::parse_bootstrap("").is_err());
+ assert!(Metadata::parse_bootstrap_servers("").is_err());
// invalid input: nonsensical address
- assert!(Metadata::parse_bootstrap("invalid_address").is_err());
+ assert!(Metadata::parse_bootstrap_servers("invalid_address").is_err());
+ }
+
+ #[test]
+ fn parse_bootstrap_accepts_comma_separated_servers() {
+ let addrs = Metadata::parse_bootstrap_servers("127.0.0.1:8080,
localhost:9090, [::1]:7070")
+ .unwrap();
+
+ assert_eq!(addrs.len(), 3);
+ assert_eq!(addrs[0].port(), 8080);
+ assert_eq!(addrs[1].port(), 9090);
+ assert_eq!(addrs[2].port(), 7070);
Review Comment:
Should assertion be done on the host/ip address value as well? Also applies
on the previous test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
