VladBanar commented on code in PR #3447:
URL: https://github.com/apache/fluss/pull/3447#discussion_r3448253674


##########
fluss-client/src/main/java/org/apache/fluss/client/converter/FlussTypeToPojoTypeConverter.java:
##########
@@ -74,6 +75,17 @@ static Object convertTextValue(
                         ConverterCommons.charLengthExceptionMessage(fieldName, 
v.length()));
             }
             return v.charAt(0);
+        } else if (pojoType.isEnum()) {
+            return Arrays.stream(pojoType.getEnumConstants())

Review Comment:
   Converter uses static methods ,but i created a map with lazy initialization



##########
fluss-client/src/main/java/org/apache/fluss/client/converter/FlussTypeToPojoTypeConverter.java:
##########
@@ -74,6 +75,17 @@ static Object convertTextValue(
                         ConverterCommons.charLengthExceptionMessage(fieldName, 
v.length()));
             }
             return v.charAt(0);
+        } else if (pojoType.isEnum()) {
+            return Arrays.stream(pojoType.getEnumConstants())
+                    .filter(e -> e.toString().equals(v.toUpperCase()))

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to