Jackeyzhe commented on issue #3483: URL: https://github.com/apache/fluss/issues/3483#issuecomment-4785106676
Thanks @binary-signal @luoyuxia for the clarification. I have pushed an update to PR #3494 and scoped it to case (1) only. The PR now only rejects `commitLakeTableSnapshot` when the target table id no longer exists in the coordinator context or has already been queued for deletion. I removed the offsets-file/table-id validation from this PR so that case (2) can be handled separately, following the discussion here. For case (2), I agree it is better to address it in a follow-up PR around the lake committer / missing-snapshot recovery path, instead of mixing it into the coordinator-side fix for case (1). The updated PR was verified with: - `CoordinatorEventProcessorTest#testCommitLakeTableSnapshotV2RejectsNonExistentTable+testCommitLakeTableSnapshotV2RejectsQueuedForDeletionTable` - `CommitLakeTableSnapshotITCase#testCommitLakeTableSnapshotV2RejectedAfterDropTable` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
