XuQianJin-Stars commented on code in PR #3518:
URL: https://github.com/apache/fluss/pull/3518#discussion_r3465663369
##########
fluss-lake/fluss-lake-hudi/src/main/java/org/apache/fluss/lake/hudi/source/HudiSplitPlanner.java:
##########
@@ -119,6 +119,9 @@ private List<HudiSplit> planPartition(
.getLatestMergedFileSlicesBeforeOrOn(partitionPath, snapshotTime)
.collect(Collectors.toList());
for (FileSlice fileSlice : fileSlices) {
+ if (fileSlice.isEmpty()) {
Review Comment:
Skipping empty file slices is correct for MOR, but please add a short
comment explaining why we can encounter an empty slice here (e.g. a pending
compaction has scheduled a new file group but no base file has been written
yet). Without that context the next reader will likely wonder if this is hiding
a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
