XuQianJin-Stars commented on code in PR #3518:
URL: https://github.com/apache/fluss/pull/3518#discussion_r3465663518
##########
fluss-lake/fluss-lake-hudi/src/test/java/org/apache/fluss/lake/hudi/tiering/HudiTieringITCase.java:
##########
@@ -97,7 +97,7 @@ protected static void beforeAll() {
@Test
Review Comment:
Flipping `enableAutoCompaction` from `false` to `true` for the existing
PK-tiering test removes coverage of the non-compaction path. Please keep the
original test (auto-compaction off) and add a new test method for
auto-compaction on; otherwise we lose a regression baseline.
##########
fluss-lake/fluss-lake-hudi/src/test/java/org/apache/fluss/lake/hudi/tiering/HudiTieringITCase.java:
##########
@@ -121,6 +121,15 @@ void testTiering() throws Exception {
checkDataInHudiMORTable(pkTablePath, "", rows, 0);
checkFlussOffsetsInSnapshot(pkTablePath,
Collections.singletonMap(pkTableBucket, 9L));
+ rows = Arrays.asList(pkRow(1, "v1111"), pkRow(2, "v2222"),
pkRow(3, "v3333"));
+ writeRows(pkTablePath, rows, false);
+
+ // 3 current records + 3 delete records + 3 insert records.
+ assertReplicaStatus(pkTableBucket, 15);
+ checkDataInHudiMORTable(pkTablePath, "", rows, 0);
+ checkFlussOffsetsInSnapshot(pkTablePath,
Collections.singletonMap(pkTableBucket, 15L));
Review Comment:
The inline comment says '3 current + 3 delete + 3 insert' (= 9) but the
assertion is `15`. Please reconcile the comment so reviewers can verify the
math.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
