litiliu commented on PR #3486: URL: https://github.com/apache/fluss/pull/3486#issuecomment-4806879655
@fresh-borzoni Thanks for the careful review. I pushed updates for the actionable comments: - Added `private.key` / `private-key` to the sensitive-key matching and covered the GCS private key cases in tests. - Reused `ConfigurationUtils.hideSensitiveValue(s)` for dynamic reconfiguration logs, so `datalake.*` credential changes are redacted as well. - Added an exact non-sensitive allowlist for the token-renewal configs using existing `ConfigOptions`, normalized case-insensitively, with lowercase/uppercase test coverage. For the S3 credential matcher unification with #3526, I’d prefer to keep that as a focused follow-up since that path is S3-specific while this PR keeps the generic log-redaction behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
