Copilot commented on code in PR #3469:
URL: https://github.com/apache/fluss/pull/3469#discussion_r3503157599
##########
fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java:
##########
@@ -599,15 +631,62 @@ public void updateLakeLogStartOffset(long
lakeHouseLogStartOffset) {
public void updateLakeLogEndOffset(long lakeLogEndOffset) {
if (lakeLogEndOffset > this.lakeLogEndOffset) {
this.lakeLogEndOffset = lakeLogEndOffset;
+ if (!hasPendingLakeBacklog()) {
+ clearPendingStartTime();
+ }
}
Review Comment:
`estimatedPendingStartTimeMs` is only advanced via
`onLakeProgressUpdated()`, but that method is currently invoked only from
`updateLakeMaxTimestamp()` when the max timestamp strictly increases. In
`notifyLakeTableOffset`, `logEndOffset` and `maxTimestamp` are updated
independently (each is optional), so lake-tiering progress can advance via
`updateLakeLogEndOffset()` without a corresponding `lakeMaxTimestamp` update
(e.g., timestamp omitted or unchanged). In that case, `pendingRecordsLag` can
keep growing even though backlog is being drained, and the estimate will not be
corrected on progress updates as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
