Prajwal-banakar opened a new pull request, #3588:
URL: https://github.com/apache/fluss/pull/3588
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were
used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the
guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close
[#fluss-rust/issues/539](https://github.com/apache/fluss-rust/issues/539)
<!-- What is the purpose of the change -->
Adds integration tests for DynamicWriteBatchSizeEstimator to verify
end-to-end behavior through a real cluster. These tests exercise the
estimator's adaptation logic — not just data integrity — by exposing the
current estimated batch size via a feature-gated accessor.
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
- Added crates/fluss/tests/integration/dynamic_batch_size.rs with 4
integration tests
1. small_rows_shrink_batch_size — writes 200 tiny rows, then asserts
estimated_batch_size_for_table() dropped below the initial max (256 KB),
proving the estimator actually shrunk
2. shrink_then_grow_batch_size — Phase 1 shrinks with tiny rows, Phase 2
sends ~200 KB rows to trigger growth; all records from both phases are read
back to verify data integrity
3. disabled_keeps_static_batch_size — writes 100 rows with
writer_dynamic_batch_size_enabled = false; verifies all records round-trip
correctly
4. concurrent_appends_share_estimator_without_corruption — 4 tokio tasks
share a single Arc<AppendWriter> from one connection, exercising concurrent
access to the shared RecordAccumulator and estimator; all 200 records are read
back
- Added #[cfg(any(test, feature = "integration_tests"))] accessor
estimated_batch_size() on RecordAccumulator
- Added #[cfg(feature = "integration_tests")] method
estimated_batch_size_for_table() on WriterClient and FlussConnection, wiring
the estimator value up to integration test code without touching the public API
- Registered the new module in crates/fluss/tests/test_fluss.rs
### Tests
<!-- List UT and IT cases to verify this change -->
cargo fmt --all
cargo clippy --all-targets --fix --allow-dirty --allow-staged - BUILD SUCCESS
cargo build --features integration_tests - BUILD SUCCESS
cargo test --workspace - BUILD SUCCESS
cargo test --features integration_tests --workspace - BUILD SUCCESS
### API and Format
<!-- Does this change affect API or storage format -->
No changes to public API or storage format.
### Documentation
<!-- Does this change introduce a new feature -->
No new feature introduced. This PR only adds integration tests for an
existing feature (DynamicWriteBatchSizeEstimator, added in #532).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
