fresh-borzoni commented on PR #3603:
URL: https://github.com/apache/fluss/pull/3603#issuecomment-4899433753
@charlesdong1991 Thank you for the review in fluss-rust, let's continue here
then
Addressing comments, PTAL
> does it hold true for Time? i think precision will change still for time?
Good catch — it was actually lossy, not just docs. Fixed: Time now carries
precision end-to-end, so TIME(p) round-trips like TIMESTAMP(p). Added a test
covering it.
> so we will drop description? i guess it is intended?
Yes, it's better to leave it as follow-up(a lot of plumbing), also python
also doesn't propagate for nested fields in ROW.
> Nit: since the targets are precision, comment and char, can we add an
integration test that create a table with those type, and then assert
get-table-info returns exactly those values?
Added a test, good call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
