beryllw commented on code in PR #3614:
URL: https://github.com/apache/fluss/pull/3614#discussion_r3542930956
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java:
##########
@@ -447,6 +450,9 @@ public CompletableFuture<DropDatabaseResponse>
dropDatabase(DropDatabaseRequest
DropDatabaseResponse response = new DropDatabaseResponse();
metadataManager.dropDatabase(
request.getDatabaseName(), request.isIgnoreIfNotExists(),
request.isCascade());
+ if (request.isCascade()) {
Review Comment:
Thanks for the change! One concern about
rebuildCurrentCount(metadataManager) in dropDatabase: it rescans all
databases/tables, but admin operations run concurrently on the coordinator. If
another request drops a database mid-scan, listTables() throws
DatabaseNotExistException, which propagates out and fails this dropDatabase
request — even with ignoreIfNotExists=true.
This is what fails the Rust IT test_error_database_already_exist in CI: its
drop_database(..., cascade=true) gets a DatabaseNotExist error for a different
database (test_create_database) that a parallel test was dropping at the same
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
