Olawoyin007 opened a new pull request, #3642: URL: https://github.com/apache/fluss/pull/3642
### Purpose Moved from apache/fluss-rust#657 at @fresh-borzoni's request, now that the `fluss-rust` repo has been merged into this monorepo. Original issue: apache/fluss-rust#636. `TableId`, `PartitionId`, and `BucketId` already have type aliases in `lib.rs`, but `snapshot_id` was still spelled `i64` everywhere. This adds a matching `SnapshotId` alias so snapshot-related signatures read consistently with the other ID types. ### Brief change log - Add `pub type SnapshotId = i64;` next to the existing aliases in `fluss-rust/crates/fluss/src/lib.rs`. - Apply it to the hand-written sites: `LakeSnapshot` (`metadata/table.rs`), `LakeSnapshotInfo`, `KvSnapshot`, `KvSnapshotLeaseForBucket`, the admin client methods (`get_kv_snapshot_metadata`, `get_lake_snapshot`), and the `GetKvSnapshotMetadataRequest` / `GetLakeSnapshotRequest` constructors. - Generated proto code is untouched; `HashMap<TableBucket, i64>` offset values stay `i64` since they are offsets, not snapshot IDs. ### Tests No behavior change (the alias resolves to the same type). `cargo build -p fluss-rs`, `cargo test -p fluss-rs --lib` (571 passed, 0 failed), and `cargo fmt -p fluss-rs --check` are all clean. ### API and Format Public signatures now name `SnapshotId` instead of `i64`; since it is a plain type alias, this is source- and ABI-compatible. No storage format impact. ### Documentation No new feature; no documentation changes needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
