litiliu commented on code in PR #3639:
URL: https://github.com/apache/fluss/pull/3639#discussion_r3585365473
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/tiering/IcebergLakeWriter.java:
##########
@@ -68,6 +68,7 @@ public IcebergLakeWriter(
throws IOException {
this.icebergCatalog = icebergCatalogProvider.get();
this.icebergTable = getTable(writerInitContext.tablePath());
+ IcebergPartitionSpecValidator.validate(icebergTable,
writerInitContext.tableInfo());
Review Comment:
It should fail only the incompatible table, not the whole tiering job. I
moved the validation out of `IcebergLakeWriter` and into
`TieringSourceEnumerator` before split generation. A validation exception is
caught by the existing per-table failure path, no splits are assigned, and the
failed table epoch is recorded for the next heartbeat so the job can continue
processing other tables. I added
`testTableValidationFailureDoesNotAssignSplits` to cover the validation-failure
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
