zuston commented on code in PR #3647:
URL: https://github.com/apache/fluss/pull/3647#discussion_r3588480877
##########
fluss-server/src/main/java/org/apache/fluss/server/tablet/TabletService.java:
##########
@@ -359,12 +362,26 @@ public CompletableFuture<GetTableStatsResponse>
getTableStats(GetTableStatsReque
public CompletableFuture<NotifyLeaderAndIsrResponse> notifyLeaderAndIsr(
NotifyLeaderAndIsrRequest notifyLeaderAndIsrRequest) {
CompletableFuture<NotifyLeaderAndIsrResponse> response = new
CompletableFuture<>();
+ int coordinatorEpoch = notifyLeaderAndIsrRequest.getCoordinatorEpoch();
List<NotifyLeaderAndIsrData> notifyLeaderAndIsrRequestData =
getNotifyLeaderAndIsrRequestData(notifyLeaderAndIsrRequest);
- replicaManager.becomeLeaderOrFollower(
- notifyLeaderAndIsrRequest.getCoordinatorEpoch(),
- notifyLeaderAndIsrRequestData,
- result ->
response.complete(makeNotifyLeaderAndIsrResponse(result)));
+ try {
+ replicaStateChangeExecutor.execute(
Review Comment:
nice suggestion. let me add the remaining rpcs into this dedicated executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
