Copilot commented on code in PR #3678:
URL: https://github.com/apache/fluss/pull/3678#discussion_r3601606438
##########
website/docs/maintenance/observability/monitor-metrics.md:
##########
@@ -406,11 +406,16 @@ Some metrics might not be exposed when using other JVM
implementations (e.g. IBM
<td>Gauge</td>
</tr>
<tr>
- <td rowspan="7">lakeTiering_table</td>
+ <td rowspan="8">lakeTiering_table</td>
<td>tierLag</td>
<td>Time in milliseconds since the last successful tiering operation for
this table. For newly registered tables that have never completed a tiering
round, the lag is measured from the time the table was registered.</td>
<td>Gauge</td>
</tr>
+ <tr>
+ <td>tieredTimestamp</td>
+ <td>The epoch timestamp (in milliseconds) of the last successful tiering
operation for this table. For newly registered tables that have never completed
a tiering round, this is the time the table was registered.</td>
+ <td>Gauge</td>
Review Comment:
The issue requirements mention returning `-1` when a table is no longer
tracked. The docs for `tieredTimestamp` currently describe the
registration-time behavior, but don’t mention the `-1` case (dropped/untracked
tables). Documenting this makes the metric’s contract clearer for monitoring
users.
##########
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java:
##########
@@ -69,6 +69,7 @@ public class MetricNames {
// for lake tiering table-level metrics
public static final String LAKE_TIERING_TABLE_TIER_LAG = "tierLag";
+ public static final String LAKE_TIERING_TABLE_TIERED_TIMESTAMP =
"tieredTimestamp";
public static final String LAKE_TIERING_TABLE_TIER_DURATION =
"tierDuration";
Review Comment:
The linked issue (#3676) specifies the new gauge name as
`lastTieredTimestamp`, but this PR introduces `tieredTimestamp`. Since metric
names are part of the public observability surface, consider aligning the name
with the issue (or updating the issue/requirements) to avoid confusion for
dashboarding and users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
