luoyuxia commented on code in PR #3630:
URL: https://github.com/apache/fluss/pull/3630#discussion_r3601898629
##########
fluss-rpc/src/main/proto/FlussApi.proto:
##########
@@ -946,6 +946,8 @@ message PbLookupReqForBucket {
optional int64 partition_id = 1;
required int32 bucket_id = 2;
repeated bytes keys = 3;
+ // The original partition name for historical lookup. It is unset for normal
lookup.
+ optional string original_partition_name = 4;
Review Comment:
I agree that this can still return a silent miss while the cluster is
running mixed TabletServer versions. However, before this change, lookup
against an expired or otherwise non-existent partition already returned null.
Before this pr, it will check partition exists or not, if not, it'll return
null then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
