Copilot commented on code in PR #3683:
URL: https://github.com/apache/fluss/pull/3683#discussion_r3602326542
##########
fluss-flink/fluss-flink-tiering/src/main/java/org/apache/fluss/flink/tiering/FlussLakeTiering.java:
##########
@@ -96,6 +97,13 @@ public FlussLakeTiering(String[] args) {
org.apache.flink.configuration.Configuration flinkConfig =
new org.apache.flink.configuration.Configuration();
flinkConfig.set(JobManagerOptions.EXECUTION_FAILOVER_STRATEGY,
FULL_RESTART_STRATEGY_NAME);
+ // Configure restart strategy: the tiering job is completely stateless
(offsets are
+ // persisted in Fluss Server's LakeSnapshot, not in Flink checkpoint
state), so it is
+ // safe to restart indefinitely on failure. Without this, Flink
defaults to "no-restart"
+ // when checkpoint is not enabled, causing the job to fail permanently
on any exception.
+ flinkConfig.set(RestartStrategyOptions.RESTART_STRATEGY,
"fixed-delay");
+ flinkConfig.set(
+ RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS,
Integer.MAX_VALUE);
Review Comment:
The restart strategy is set to "fixed-delay" with a very large attempts
count, but the fixed-delay *delay* is left at Flink’s default. This can lead to
a tight restart loop (or behavior changes if Flink’s default changes). Other
parts of the codebase set the delay explicitly when using fixed-delay (e.g.
UndoRecoveryITCase#getFileBasedCheckpointsConfig). Consider setting
RESTART_STRATEGY_FIXED_DELAY_DELAY here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
