luoyuxia commented on code in PR #3618:
URL: https://github.com/apache/fluss/pull/3618#discussion_r3607962910
##########
website/docs/maintenance/configuration.md:
##########
@@ -54,6 +54,22 @@ during the Fluss cluster working.
| server.io-pool.size | Integer |
10
| The size of the IO thread pool to run blocking operations for both
coordinator and tablet servers. This includes discard unnecessary snapshot
files, transfer kv snapshot files, and transfer remote log files. Increase this
value if you experience slow IO operations. The default value is 10.
|
+## Environment
+
+The following options control the launch environment of the Fluss server
processes, such as the JVM options and the directory for process id files. They
are set in `conf/server.yaml` and are applied by the startup scripts under
`bin/` when starting the CoordinatorServer and TabletServer.
+
+| Option | Type | Default | Description
|
+|----------------------------------|--------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| env.java.home | String | (None) | Path to the JDK/JRE
used to run the Fluss processes. If not set, the system `JAVA_HOME` or the
`java` binary found on the `PATH` is used.
|
+| env.java.opts.all | String | (None) | JVM options applied to
all Fluss server processes, i.e. both the CoordinatorServer and the
TabletServer, for example `-Xmx4g -XX:+UseG1GC`. Note that the startup scripts
always prepend `-XX:+IgnoreUnrecognizedVMOptions` (and
`-Djava.security.manager=allow` on JDK 18+) to these options.
|
Review Comment:
The ordering described here does not match `bin/config.sh`. The script first
constructs `-XX:+IgnoreUnrecognizedVMOptions <env.java.opts.all>` and then, on
JDK 18+, appends `-Djava.security.manager=allow`, so the latter is not
prepended. Also, the entire injection is guarded by `[ -z
"${FLUSS_ENV_JAVA_OPTS}" ]`, so it is skipped when that environment variable is
already set. Could we describe this as: "When `FLUSS_ENV_JAVA_OPTS` is not
already set, the startup scripts prepend `-XX:+IgnoreUnrecognizedVMOptions` to
the configured options and, on JDK 18+, append `-Djava.security.manager=allow`."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
