wuchong commented on code in PR #3623:
URL: https://github.com/apache/fluss/pull/3623#discussion_r3612266593
##########
fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java:
##########
@@ -556,10 +594,10 @@ public void updateRemoteLogSize(long remoteLogSize) {
public void updateRemoteLogEndOffset(long remoteLogEndOffset) {
if (remoteLogEndOffset > this.remoteLogEndOffset) {
this.remoteLogEndOffset = remoteLogEndOffset;
-
- // try to delete these segments already exist in remote storage.
- deleteSegmentsAlreadyExistsInRemote();
}
+
+ // try to delete these segments already exist in remote storage.
+ deleteSegmentsAlreadyExistsInRemote();
Review Comment:
We don't need to move this out of the if block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
