qingwen220 commented on code in PR #712: URL: https://github.com/apache/geaflow/pull/712#discussion_r2619007499
########## geaflow/geaflow-utils/src/main/java/org/apache/geaflow/utils/keygroup/KeyGroupAssignment.java: ########## @@ -27,6 +27,10 @@ import java.util.concurrent.ConcurrentHashMap; import org.apache.geaflow.utils.math.MathUtil; +/* This file is based on source code from the Flink Project (http://flink.apache.org/), licensed by the Apache + * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for + * additional information regarding copyright ownership. */ + /** * This class is an adaptation of Flink's org.apache.flink.runtime.state.KeyGroupRangeAssignment. */ Review Comment: There are two similar declarations, and we can keep one. ########## geaflow/geaflow-dashboard/web-dashboard/src/components/Footer/index.tsx: ########## @@ -7,7 +26,7 @@ const Footer: React.FC = () => { const intl = useIntl(); const defaultMessage = intl.formatMessage({ id: 'app.copyright.produced', - defaultMessage: '蚂蚁集团', + defaultMessage: 'Apache GeaFlow(孵化中)', Review Comment: Apache GeaFlow(incubating) ########## geaflow-kubernetes-operator/geaflow-kubernetes-operator-web/web-dashboard/src/components/Footer/index.tsx: ########## @@ -7,7 +26,7 @@ const Footer: React.FC = () => { const intl = useIntl(); const defaultMessage = intl.formatMessage({ id: 'app.copyright.produced', - defaultMessage: '蚂蚁集团', + defaultMessage: 'Apache GeaFlow(孵化中)', Review Comment: Apache GeaFlow(孵化中) -> Apache GeaFlow(Incubating) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
