kitalkuyo-gita commented on code in PR #716: URL: https://github.com/apache/geaflow/pull/716#discussion_r2689045804
########## geaflow-ai/src/main/java/org/apache/geaflow/ai/session/SessionManagement.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.geaflow.ai.session; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import org.apache.geaflow.ai.common.config.Constants; +import org.apache.geaflow.ai.subgraph.SubGraph; + +public class SessionManagement { + + public static final SessionManagement INSTANCE = new SessionManagement(); + private final Map<String, Long> session2ActiveTime = new HashMap<>(); + private final Map<String, List<SubGraph>> session2Graphs = new HashMap<>(); + + private SessionManagement() { + } + + public boolean createSession(String sessionId) { + if (session2ActiveTime.containsKey(sessionId)) { + return false; + } + session2ActiveTime.put(sessionId, System.nanoTime()); + return true; + } + + public String createSession() { + String sessionId = Constants.PREFIX_TMP_SESSION + System.nanoTime() + + UUID.randomUUID().toString().replace("-", "").substring(0, 8); + if (createSession(sessionId)) { + return sessionId; + } else { + return null; + } + } + + public boolean sessionExists(String session) { + return this.session2ActiveTime.containsKey(session); + } + + public List<SubGraph> getSubGraph(String sessionId) { + return this.session2Graphs.get(sessionId); + } + + public void setSubGraph(String sessionId, List<SubGraph> subGraphs) { + this.session2Graphs.put(sessionId, subGraphs); Review Comment: samples: ``` // 将 Map 改为并发实现 private final ConcurrentMap<String, Long> session2ActiveTime = new ConcurrentHashMap<>(); private final ConcurrentMap<String, List<SubGraph>> session2Graphs = new ConcurrentHashMap<>(); public boolean createSession(String sessionId) { if (sessionId == null) { return false; } Long prev = session2ActiveTime.putIfAbsent(sessionId, System.nanoTime()); if (prev != null) { return false; } // 初始化 subgraphs 为可变空列表，避免 NPE session2Graphs.putIfAbsent(sessionId, new ArrayList<>()); return true; } public String createSession() { String sessionId = Constants.PREFIX_TMP_SESSION + System.nanoTime() + UUID.randomUUID().toString().replace("-", "").substring(0, 8); return createSession(sessionId) ? sessionId : null; } // 返回不可为 null 的 List（防止调用者 NPE） public List<SubGraph> getSubGraph(String sessionId) { List<SubGraph> l = this.session2Graphs.get(sessionId); return l == null ? new ArrayList<>() : l; } public void setSubGraph(String sessionId, List<SubGraph> subGraphs) { // 安全性：确保 map 存在 key this.session2Graphs.put(sessionId, subGraphs == null ? new ArrayList<>() : subGraphs); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
