wr-web opened a new pull request, #725: URL: https://github.com/apache/geaflow/pull/725
Remove incorrect Py_DECREF call for marker. ### Related Code https://github.com/apache/geaflow/blob/f891ede132df65026ff71aa43f83a12dcfdbecdd/geaflow/geaflow-infer/src/main/resources/infer/inferRuntime/mmap_ipc.cpp#L6587-L6589 [PyList_SetItem Source Code](https://github.com/python/cpython/blob/a126893fa80c4ee5f0bac8a84a49491c19edd511/Objects/listobject.c#L454) [PyList_SetItem Document](https://docs.python.org/3/c-api/list.html#c.PyList_SetItem) [PyList_SetItem Python Forum Discussion](https://discuss.python.org/t/proper-handling-of-pylist-setitem-return-value-and-reference-stealing-in-cpython-c-extensions/105805) Therefore, whether the function succeeds or fails, it will steal a reference count of the third argument. It must not call `Py_DECREF` in case of failure. ### How was this PR tested? - [x] Tests have Added for the changes - [x] Production environment verified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
