[
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712679#comment-15712679
]
ASF GitHub Bot commented on GEODE-734:
--------------------------------------
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/297#discussion_r90506480
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowStackTraceDUnitTest.java
---
@@ -90,6 +90,20 @@ public void run() {
public void testExportStacktrace() throws ClassNotFoundException,
IOException {
setupSystem();
+ // Test non txt extension file is allowed
+ File stacktracesFile = new File("allStackTraces.log");
--- End diff --
Files should be created in a TemporaryFolder. Please see TemporaryFolder on
https://github.com/junit-team/junit4/wiki/Rules.
We have a version of TemporaryFolder which works in DUnit
(DistributedTests). See
org.apache.geode.test.junit.rules.serializable.SerializableTemporaryFolder.
The TemporaryFolder Rule automatically takes care of deleting files and
directories after each test.
> gfsh export stack-traces should not require an output file with extension .txt
> ------------------------------------------------------------------------------
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should
> have a user prompt indicating that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
