Dan Smith created GEODE-2175:
--------------------------------
Summary: CI failure from
TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime
Key: GEODE-2175
URL: https://issues.apache.org/jira/browse/GEODE-2175
Project: Geode
Issue Type: Bug
Reporter: Dan Smith
{noformat}
org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest
> expectErrorAfterWaitTime FAILED
java.lang.Exception: Unexpected exception,
expected<org.apache.geode.cache.execute.FunctionException> but
was<java.lang.AssertionError>
Caused by:
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at
org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime(TopEntriesFunctionCollectorJUnitTest.java:195)
{noformat}
Looking at this test, it looks like it's a race condition waiting to happen
because it does a bunch of 1 second awaits.
I'm also suspicious of the functionality that is being tested here in the first
place. A user's result collector shouldn't have to contain logic to wait for
all of the results to be gather, that's handled by the function execution
framework. So the real fix may be to remove these tests and the logic in
TopEntriesFunctionCollector that waits for the results to be gathered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
