[
https://issues.apache.org/jira/browse/GEODE-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719668#comment-15719668
]
ASF GitHub Bot commented on GEODE-1984:
---------------------------------------
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/303
GEODE-1984: Fix Issue Make GatewaySender destroy a public API
1. Making destory API public
2. Added a new gfsh WAN command destroyGatewaySender
3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender
and then call destroy on the same.
4. Added a WAN Rest Controller for destroy gatewaysender
5. Removed the need of explicit casting of sender to
AbstractGatewaySender for calling
destroy API
6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to
WanCommandCreateDestroyGatewaySenderDUnitTest
7. Each applicable test now also calls destroy gfsh command and verfies
the result
8. Minor changes in the logging for each tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/incubator-geode bugfix/GEODE-1984
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit 610b620e12b3b8f4198238cd562d5c3f0d8cd669
Author: adongre <[email protected]>
Date: 2016-12-03T14:08:39Z
GEODE-1984: Fix Issue Make GatewaySender destroy a public API
1. Making destory API public
2. Added a new gfsh WAN command destroyGatewaySender
3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender
and then call destroy on the same.
4. Added a WAN Rest Controller for destroy gatewaysender
5. Removed the need of explicit casting of sender to
AbstractGatewaySender for calling
destroy API
6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to
WanCommandCreateDestroyGatewaySenderDUnitTest
7. Each applicable test now also calls destroy gfsh command and verfies
the result
8. Minor changes in the logging for each tests
----
> Make GatewaySender destroy a public API
> ---------------------------------------
>
> Key: GEODE-1984
> URL: https://issues.apache.org/jira/browse/GEODE-1984
> Project: Geode
> Issue Type: New Feature
> Components: wan
> Reporter: Barry Oglesby
> Assignee: Avinash Dongre
>
> The internal {{AbstractGatewaySender}} class has a {{destroy}} API to destroy
> a {{GatewaySender}}. This is currently an internal API. It would be nice to
> make this public by:
> - adding destroy to the {{GatewaySender}} interface
> - provide {{gfsh}} support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
