[ https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724297#comment-15724297 ]
ASF GitHub Bot commented on GEODE-1835: --------------------------------------- GitHub user ameybarve15 opened a pull request: https://github.com/apache/incubator-geode/pull/304 GEODE-1835: A message logged by the configure pdx command is incorrect You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-1835 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #304 ---- commit 7cd0475c70ca5d149a6d822541063dabc39835f4 Author: Amey Barve <aba...@apache.org> Date: 2016-12-05T06:26:25Z GEODE-1835 : logging a warning message by the configure pdx command only when there are members in the distributed system. commit 150c3da92e1bb23d6c251ee728033dc88b235e2d Author: Amey Barve <aba...@apache.org> Date: 2016-12-05T12:54:18Z GEODE-1835 : unit test to verify a warning message by the configure pdx command only when there are members in the distributed system. ---- > A message logged by the configure pdx command is incorrect > ---------------------------------------------------------- > > Key: GEODE-1835 > URL: https://issues.apache.org/jira/browse/GEODE-1835 > Project: Geode > Issue Type: Bug > Components: gfsh > Reporter: Barry Oglesby > Assignee: Amey Barve > > The message below is only logged when there are no members. Instead, it > should be logged when there are members. > {noformat} > The command would only take effect on new data members joining the > distributed system. It won't affect the existing data members > {noformat} > The condition in {{PDXCommands.configurePDX}} is: > {noformat} > if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) { > ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING); > } > {noformat} > It should test for {{!isEmpty}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)