[
https://issues.apache.org/jira/browse/GEODE-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042296#comment-16042296
]
ASF GitHub Bot commented on GEODE-290:
--------------------------------------
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/568
GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncher…
Removed deprecated properties.
Modified test cases to use alternate constants.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
Yes. GEODE-290
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
Modified existing test cases.
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deepakddixit/incubator-geode GEODE-290
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #568
----
commit 920a8d13fb5ec221e1359e9ea6887d31f21d15d7
Author: Deepak Dixit <[email protected]>
Date: 2017-06-06T17:09:14Z
GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncher.
Removed deprecated properties.
Modified test cases to use alternate constants.
----
> Remove deprecated APIs from Locator/Server Launcher classes
> -----------------------------------------------------------
>
> Key: GEODE-290
> URL: https://issues.apache.org/jira/browse/GEODE-290
> Project: Geode
> Issue Type: Sub-task
> Components: management
> Reporter: Kirk Lund
>
> Remove deprecated method from LocatorLauncher:
> * LocatorLauncher.stopWithPort()
> Remove deprecated protected/public constants from LocatorLauncher:
> * LocatorLauncher.DEFAULT_LOCATOR_PORT
> * LocatorLauncher.DEFAULT_ENABLE_PEER_LOCATION
> * LocatorLauncher.DEFAULT_ENABLE_SERVER_LOCATION
> * LocatorLauncher.DEFAULT_LOCATOR_PID_FILE
> Remove deprecated protected/public constants from ServerLauncher:
> * ServerLauncher.DEFAULT_SERVER_PORT
> * ServerLauncher.DEFAULT_SERVER_PID_FILE
> The above were all marked as deprecated in 8.0 because they are too specific
> to the implementation which changed some in 8.0 to support a simple
> file-based control in addition to the Attach API control that was introduced
> in 7.0. For example, future changes may remove the pid file altogether.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
