[
https://issues.apache.org/jira/browse/GEODE-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044840#comment-16044840
]
ASF GitHub Bot commented on GEODE-3021:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/565#discussion_r121196596
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object
outerEntries, Object innerEntries
*/
synchronized void setPdxStringFlag(Object key) {
// For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet
flag
- if (key == null || key == IndexManager.NULL || key ==
QueryService.UNDEFINED) {
+ if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL
--- End diff --
They are slightly different. The isIndexedPdxKeys is represents whether
the index is storing pdx as keys. The isIndexedPdxKeysFlagSet, is a boolean
that is used as a short circuit to only call the method once. I guess it was a
performance "enhancement" to not call the method over and over for every value
and just call it only for the first call.
> OQL Index isIndexedPdxKeys potential concurrency issue
> ------------------------------------------------------
>
> Key: GEODE-3021
> URL: https://issues.apache.org/jira/browse/GEODE-3021
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
> The boolean isIndexedPdxKeys is set in a synchronized method. However
> multiple threads could be making a call to this method, the last caller would
> set the flag based on it's key, either true or false, but the previous
> callers could have meant to set it to the opposite.
> This method sets isIndexedPdxKeysFlagSet afterwards and hopes that callers to
> this method check this flag first. However, again, multiple threads could
> have checked this flag, seen it as false, and then all attempted to call the
> synchronized method.
> The solution is to probably check the isIndexedPdxKeysFlagSet flag in the
> method also. That way, if another thread had already completed
> setPdxStringFlag(), the next call would be a no-op.
> The current issue will lead to possible class cast exceptions from String to
> PdxString or vice versa
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
