Galen O'Sullivan created GEODE-3059:
---------------------------------------

             Summary: LoadMonitor.connectionClosed incrementing statistics only 
for client-server connection
                 Key: GEODE-3059
                 URL: https://issues.apache.org/jira/browse/GEODE-3059
             Project: Geode
          Issue Type: Bug
            Reporter: Galen O'Sullivan


The logic in {{LoadMonitor.connectionClosed}} looks wrong, or at least is quite 
counterintuitive. The connection count is decremented only if this is a 
client-server connection, which looks wrong, and the client count should be 
only if it's a client-to-server connection.

We need to look at Gateway connections as well, and for the new client-server 
protocol.

{code}
  public void connectionClosed(boolean lastConnection, byte communicationMode) {
    if (communicationMode == Acceptor.CLIENT_TO_SERVER) {
      metrics.decConnectionCount();
    }
    if (lastConnection) {
      metrics.decClientCount();
    }
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to