[
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045350#comment-16045350
]
ASF GitHub Bot commented on GEODE-2741:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/102#discussion_r121248442
--- Diff: src/CMakeLists.txt ---
@@ -17,6 +17,15 @@ project(nativeclient)
list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/../cmake)
+if(CMAKE_GENERATOR MATCHES Win64*)
+ if ((CMAKE_GENERATOR MATCHES "Visual Studio") AND
(CMAKE_GENERATOR_TOOLSET STREQUAL ""))
--- End diff --
Why not just set the `CMAKE_GENERATOR_TOOLSET`?
> Use C++11 shared pointer over custom shared pointer
> ---------------------------------------------------
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
> Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
