[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047957#comment-16047957
 ] 

ASF GitHub Bot commented on GEODE-3048:
---------------------------------------

Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/575#discussion_r121690706
  
    --- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java
 ---
    @@ -26,7 +26,9 @@
     import java.util.Map;
     import java.util.Set;
     
    +import org.apache.geode.test.dunit.rules.RequiresGeodeHome;
    --- End diff --
    
    Reorder imports - looks like there are several files that should have the 
imports reordered. I'd suggest reviewing all of the tests modified and use the 
IDE to reorder the imports.


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> ---------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3048
>                 URL: https://issues.apache.org/jira/browse/GEODE-3048
>             Project: Geode
>          Issue Type: Bug
>          Components: management, tests
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to