[
https://issues.apache.org/jira/browse/GEODE-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048421#comment-16048421
]
ASF GitHub Bot commented on GEODE-1958:
---------------------------------------
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/578#discussion_r121799720
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java ---
@@ -1909,10 +1900,7 @@ private static boolean needsSysDir(String cmd) {
if (cmd.equalsIgnoreCase("version")) {
return false;
}
- if (cmd.equalsIgnoreCase("help")) {
- return false;
- }
- return true;
+ return !cmd.equalsIgnoreCase("help");
--- End diff --
If you want to collapse this block, I think this might read a little better.
```
if (cmd.equalsIgnoreCase("stats")
|| cmd.equalsIgnoreCase("merge-logs")
|| cmd.equalsIgnoreCase("version")
|| cmd.equalsIgnoreCase("help")) {
return false;
}
return true;
```
I guess you could collapse that to a one-liner, but I don't think that
would read as well.
> Remove PasswordUtil
> --------------------
>
> Key: GEODE-1958
> URL: https://issues.apache.org/jira/browse/GEODE-1958
> Project: Geode
> Issue Type: Bug
> Components: security
> Reporter: Diane Hardman
> Assignee: Emily Yeh
> Priority: Minor
>
> PasswordUtil was used to encrypt a password to be stored in cache.xml. This
> was not secure since anyone could copy the "encrypted" string to another
> cache.xml to gain access. Therefore this utility was not particularly useful
> and should be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
