[
https://issues.apache.org/jira/browse/GEODE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052187#comment-16052187
]
ASF GitHub Bot commented on GEODE-2018:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/587
GEODE-2018: Added instantiators to SessionCachingFilter init method
Also removed unused registerInstantiator methods from
GatewayDeltaCreateEvent,
GatewayDeltaDestroyEvent, and DeltaSessionDestroyAttrbiuteEvent classes.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-2018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/587.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #587
----
commit 917487bd593ed96d4135d6a057a1f172bd7e188e
Author: David Anuta <[email protected]>
Date: 2017-06-16T17:44:05Z
GEODE-2018: Added instantiators to SessionCachingFilter init method
Also removed unused registerInstantiator methods from
GatewayDeltaCreateEvent,
GatewayDeltaDestroyEvent, and DeltaSessionDestroyAttrbiuteEvent classes.
----
> SessionCachingFilter should register Instantiators in the init method
> ---------------------------------------------------------------------
>
> Key: GEODE-2018
> URL: https://issues.apache.org/jira/browse/GEODE-2018
> Project: Geode
> Issue Type: Improvement
> Components: http session
> Reporter: Dan Smith
> Assignee: David Anuta
>
> The session caching module for generic appservers uses instantiators for
> things like GemFireHttpSession.
> We recommend best practice is to register instantiators on startup, but the
> SessionCachingFilter doesn't do that. We should register these instatiators
> in the init method of that class, rather than waiting for the classloader to
> load the GemfireHttpSession class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
