[
https://issues.apache.org/jira/browse/GEODE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052225#comment-16052225
]
ASF GitHub Bot commented on GEODE-2820:
---------------------------------------
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/588
GEODE-2820: Added awaitlity clause to wait for the region size to be …
…correct
* Added awaitility clause to wait for all the regions to have all the
entries
* This is done to make sure that the queries are executed.
* This may not solve the issue of queries being executed before async
index is updated
* However this shortens the window of failure happening.
Potential reviewers
@jhuynh1
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/588.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #588
----
commit 61ebad2b6d8f2b06a69f1de669e1be49008b6136
Author: nabarun <[email protected]>
Date: 2017-06-15T23:32:46Z
GEODE-2820: Added awaitlity clause to wait for the region size to be correct
* Added awaitility clause to wait for all the regions to have all the
entries
* This is done to make sure that the queries are executed.
* This may not solve the issue of queries being executed before async
index is updated
* However this shortens the window of failure happening.
----
> QueryIndexUsingXMLDUnitTest.testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults
> is disabled
> -----------------------------------------------------------------------------------------------
>
> Key: GEODE-2820
> URL: https://issues.apache.org/jira/browse/GEODE-2820
> Project: Geode
> Issue Type: Test
> Components: querying, tests
> Reporter: Kirk Lund
> Labels: CI
>
> The test has an @Ignore annotation with value of "TODO: test is disabled
> because of #52167"
> This test should be fixed and reenabled.
> The original bug described this test as flaky and provided this old stack
> trace:
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.query.dunit.QueryIndexUsingXMLDUnitTest$11.run in
> VM 1 running on Host ent.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:357)
> at dunit.VM.invoke(VM.java:301)
> at dunit.VM.invoke(VM.java:255)
> at
> com.gemstone.gemfire.cache.query.dunit.QueryIndexUsingXMLDUnitTest.testCreateAsyncIndexWhileDoingGIIAndCompareQueryResults(QueryIndexUsingXMLDUnitTest.java:617)
> Caused by:
> junit.framework.AssertionFailedError: FAILED:SelectResults size is different
> in both the cases. Size1=490 Size2 = 489; failed query=Select * from
> /Portfolios where ID > 10
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
