[
https://issues.apache.org/jira/browse/GEODE-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054930#comment-16054930
]
ASF GitHub Bot commented on GEODE-3073:
---------------------------------------
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/591#discussion_r122848112
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
---
@@ -1415,11 +1413,7 @@ public boolean evaluateCq(ExecutionContext context)
throws FunctionDomainExcepti
// add UNDEFINED to results only for NOT EQUALS queries
if (this.whereClause.getType() == COMPARISON) {
int operator = ((Filter) this.whereClause).getOperator();
- if ((operator != TOK_NE && operator != TOK_NE_ALT)) {
- return false;
- } else {
- return true;
- }
+ return !(operator != TOK_NE && operator != TOK_NE_ALT);
--- End diff --
That's a lot of negatives. `return operator == TOK_NE || operator ==
TOK_NE_ALT` read better, in my opinion.
> Refactor/rename OrderByComparatorUnmapped
> -----------------------------------------
>
> Key: GEODE-3073
> URL: https://issues.apache.org/jira/browse/GEODE-3073
> Project: Geode
> Issue Type: Improvement
> Components: querying
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> It would make more sense to rename {{OrderByComparatorUnmapped.java}} to
> {{OrderByComparatorMapped.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
