[
https://issues.apache.org/jira/browse/GEODE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054986#comment-16054986
]
ASF GitHub Bot commented on GEODE-2995:
---------------------------------------
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/593
GEODE-2995: Handle stream of ProtoBuf encoded messages
This for now exists in isolation, but will be hooked up with the code
currently in review for GEODE-3075
Signed-off-by: Alexander Murmann <[email protected]>
Signed-off-by: Brian Rowe <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x ] Is your initial contribution a single, squashed commit?
- [x ] Does `gradlew build` run cleanly?
- [x ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@metatype I think we've run this license by you, but here's the protobuf
license again:
https://github.com/google/protobuf/blob/master/LICENSE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-2995
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #593
----
commit 51b6ee1a817f48c924e5beefaaf2329cf33ed612
Author: Udo Kohlmeyer <[email protected]>
Date: 2017-06-12T22:12:18Z
GEODE-2995: Handle stream of ProtoBuf encoded messages
This for now exists in isolation, but will be hooked up with the code
currently in review for GEODE-3075
Signed-off-by: Alexander Murmann <[email protected]>
Signed-off-by: Brian Rowe <[email protected]>
----
> Introduce new protocol flow into core
> -------------------------------------
>
> Key: GEODE-2995
> URL: https://issues.apache.org/jira/browse/GEODE-2995
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Brian Baynes
> Assignee: Udo Kohlmeyer
>
> Create new protocol flow in core to handle incoming client messages,
> serialize/de-serialize primitives and JSON, construct/de-construct messages,
> and complete operations with response.
> New protocol flow should handle put/get messages with response, covering
> primitives and JSON.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)