[
https://issues.apache.org/jira/browse/GEODE-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057438#comment-16057438
]
ASF GitHub Bot commented on GEODE-3104:
---------------------------------------
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/595
GEODE-3104 : Modified code to use --include-locators instead of existing
--shutdown-locators option in shutdown command.
GEODE-3104 : Modified code to use --include-locators instead of existing
--shutdown-locators option in shutdown command.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-3104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #595
----
commit 844184983396708d0fda272b74f818c566a8cf9c
Author: Amey Barve <[email protected]>
Date: 2017-06-21T12:57:01Z
GEODE-3104 : Modified code to use --include-locators instead of existing
--shutdown-locators option in shutdown command.
----
> gfsh gives the wrong advice when issuing shutdown
> -------------------------------------------------
>
> Key: GEODE-3104
> URL: https://issues.apache.org/jira/browse/GEODE-3104
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Bruce Schuchardt
> Assignee: Amey Barve
>
> I was trying to shut down my whole distributed system and gfsh told me to use
> the wrong option in order to have "shutdown" include the locator. It said I
> should use --shutdown-locators but the option is --include-locators.
> {noformat}
> gfsh>shutdown
> As a lot of data in memory will be lost, including possibly events in queues,
> do you really want to shutdown the entire distributed system? (Y/n): Y
> No data node found for stopping. Please specify --shutdown-locators option if
> you want locators to be stopped
> gfsh>shutdown --shutdown-locators
> Option 'shutdown-locators' is not available for this command. Use tab assist
> or the "help" command to see the legal options
> gfsh>list members
> Name | Id
> -------- | --------------------------------------------------
> locator1 | 10.118.26.122(locator1:21797:locator)<ec><v0>:1024
> gfsh>shutdown --
> --include-locators --time-out
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
