[
https://issues.apache.org/jira/browse/GEODE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057700#comment-16057700
]
ASF subversion and git services commented on GEODE-2861:
--------------------------------------------------------
Commit 5039e62af85795e5448fa746969d001782922cc9 in geode's branch
refs/heads/develop from [~nreich]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5039e62 ]
GEODE-2861: Remove dead code
* code removed related to shutting down DiskStoreTaskPool
* this closes #594
> remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
> ---------------------------------------------------------------------------
>
> Key: GEODE-2861
> URL: https://issues.apache.org/jira/browse/GEODE-2861
> Project: Geode
> Issue Type: Improvement
> Components: persistence
> Affects Versions: 1.0.0-incubating
> Reporter: Darrel Schneider
> Assignee: Nick Reich
> Priority: Trivial
> Labels: storage_3
>
> Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting
> down the DiskStoreTaskPool.
> On DiskStoreImpl see these methods:
> stopDiskStoreTaskPool
> shutdownPool
> On GemFireCacheImpl the field diskStoreTaskPool is always null.
> Note that a bug exists in this deadcode that causes it to not call
> taskCancelled as it iterates over a list of runnables. Since this code is
> dead it is currently doing no harm but if the code is not removed then make
> sure and fix this loop.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
