[
https://issues.apache.org/jira/browse/GEODE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061372#comment-16061372
]
ASF GitHub Bot commented on GEODE-2920:
---------------------------------------
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123820699
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
---
@@ -109,12 +107,10 @@ public Result listClient() {
}
String memberSeparator = "; ";
- Iterator<Entry<String, List<String>>> it =
clientServerMap.entrySet().iterator();
- while (it.hasNext()) {
- Map.Entry<String, List<String>> pairs = (Map.Entry<String,
List<String>>) it.next();
- String client = (String) pairs.getKey();
- List<String> servers = (List<String>) pairs.getValue();
+ for (Entry<String, List<String>> pairs : clientServerMap.entrySet())
{
+ String client = pairs.getKey();
+ List<String> servers = pairs.getValue();
StringBuilder serverListForClient = new StringBuilder();
--- End diff --
Since we're already cleaning up this section of the code, it might be worth
considering replacing 114-123 with a one liner:
```
String serverListForClient =
servers.stream().collect(Collectors.joining(memberSeparator));
```
> secure disk-store as a resource
> -------------------------------
>
> Key: GEODE-2920
> URL: https://issues.apache.org/jira/browse/GEODE-2920
> Project: Geode
> Issue Type: Sub-task
> Components: security
> Reporter: Swapnil Bawaskar
>
> Treat DISK as a CLUSTER resource so that administrators can control the
> ability to manage diskstores/create regions that will write to disk stores.
> Only a user with CLUSTER:MANAGE:DISK should be able to run the following gfsh
> commands:
> {noformat}
> create disk-store
> alter disk-store
> compact disk-store
> destroy disk-store
> revoke missing-disk-store
> {noformat}
> And the following JMX bean methods:
> {noformat}
> DiskStoreMXBean.forceCompaction
> DiskStoreMXBean.flush
> DiskStoreMXBean.forceRoll
> DiskStoreMXBean.setDiskUsageCriticalPercentage
> DiskStoreMXBean.setDiskUsageWarningPercentage
> DistributedSystemMXBean.revokeMissingDiskStores
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
