[ 
https://issues.apache.org/jira/browse/GEODE-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063525#comment-16063525
 ] 

ASF GitHub Bot commented on GEODE-3117:
---------------------------------------

GitHub user kirklund opened a pull request:

    https://github.com/apache/geode/pull/601

    GEODE-3117: fix Gateway authentication with legacy security

    * add GatewayLegacyAuthenticationRegressionTest to reproduce bug
    * fix authentication of Gateway sender/receiver with
    SECURITY_CLIENT_AUTHENTICATOR
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [x ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [x ] Is your initial contribution a single, squashed commit?
    
    - [x ] Does `gradlew build` run cleanly?
    
    - [x ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to [email protected].


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kirklund/geode GEM-1523

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #601
    
----
commit 71a02f6991ce8ce2874c11482b99cba30f5d6d90
Author: Kirk Lund <[email protected]>
Date:   2017-06-16T23:33:17Z

    GEODE-3117: fix Gateway authentication with legacy security
    
    * add GatewayLegacyAuthenticationRegressionTest to reproduce bug
    * fix authentication of Gateway sender/receiver with
    SECURITY_CLIENT_AUTHENTICATOR

----


> Gateway authentication throws NullPointerException
> --------------------------------------------------
>
>                 Key: GEODE-3117
>                 URL: https://issues.apache.org/jira/browse/GEODE-3117
>             Project: Geode
>          Issue Type: Bug
>          Components: security, wan
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>         Attachments: geode-3117.tar
>
>
> {noformat}
> java.lang.NullPointerException
>         at 
> org.apache.geode.security.templates.DummyAuthenticator.authenticate(DummyAuthenticator.java:50)
>         at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.verifyCredentials(HandShake.java:1699)
>         at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.checkIfAuthenticWanSite(HandShake.java:1746)
>         at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1409)
>         at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.handshakeWithServer(HandShake.java:1258)
>         at 
> org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:117)
>         at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:136)
>         at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:259)
>         at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.borrowConnection(ConnectionManagerImpl.java:206)
>         at 
> org.apache.geode.cache.client.internal.PoolImpl.acquireConnection(PoolImpl.java:898)
>         at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.initializeConnection(GatewaySenderEventRemoteDispatcher.java:402)
>         at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:317)
>         at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher._dispatchBatch(GatewaySenderEventRemoteDispatcher.java:199)
>         at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.dispatchBatch(GatewaySenderEventRemoteDispatcher.java:148)
>         at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:609)
>         at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor.run(SerialGatewaySenderEventProcessor.java:223)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to