[
https://issues.apache.org/jira/browse/GEODE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063588#comment-16063588
]
ASF GitHub Bot commented on GEODE-3130:
---------------------------------------
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/602
GEODE-3130: Refactoring AcceptorImpl
We extracted a switch statement in AcceptorImpl.handleNewClientConnection
to a new method.
Signed-off-by: Alexander Murmann <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-3130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #602
----
commit 01784841e4cfdb6750159aab286b734336df3467
Author: Brian Rowe <[email protected]>
Date: 2017-06-26T18:22:03Z
GEODE-3130: Refactoring AcceptorImpl
We extracted a switch statement in AcceptorImpl.handleNewClientConnection
to a new method.
Signed-off-by: Alexander Murmann <[email protected]>
----
> Refactor communication mode handling in AcceptorImpl.handleNewClientConnection
> ------------------------------------------------------------------------------
>
> Key: GEODE-3130
> URL: https://issues.apache.org/jira/browse/GEODE-3130
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Brian Rowe
>
> This is pending review feedback from the implementation of 2995 which didn't
> get addressed prior to the merge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
