[
https://issues.apache.org/jira/browse/GEODE-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075097#comment-16075097
]
ASF GitHub Bot commented on GEODE-3167:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/618
GEODE-3167: Added commons-validator dependency to modify_war script a…
…nd Tomcat required jars
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-3167
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/618.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #618
----
commit 5d5ede50a1367f6851b3c9eb5db7a843b84cb4ac
Author: David Anuta <[email protected]>
Date: 2017-07-05T17:12:01Z
GEODE-3167: Added commons-validator dependency to modify_war script and
Tomcat required jars
----
> Missing dependency in modify_war script
> ---------------------------------------
>
> Key: GEODE-3167
> URL: https://issues.apache.org/jira/browse/GEODE-3167
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: David Anuta
> Assignee: David Anuta
> Fix For: 1.3.0
>
>
> Since commons-validator was added as a a required jar in GEODE-2804 the Cargo
> session tests added in GEODE-2901 have been failing due to the missing
> dependency. The commons-validator jar needs to be added to the modify_war
> script as well as the list of required jars for Tomcat.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
