[
https://issues.apache.org/jira/browse/GEODE-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086038#comment-16086038
]
ASF GitHub Bot commented on GEODE-3019:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278256
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return SelectResultsIterator(m_structVector, shared_from_this());
}
-int32_t StructSetImpl::getFieldIndex(const char* fieldname) {
- std::map<std::string, int32_t>::iterator iter =
+int32_t StructSetImpl::getFieldIndex(const std::string& fieldname) {
--- End diff --
should this method be a const method?
> Refactor Struct
> ---------------
>
> Key: GEODE-3019
> URL: https://issues.apache.org/jira/browse/GEODE-3019
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Jacob S. Barrett
>
> Refactor Struct (geode/Struct.hpp):
> * Replace {{char *}} with {{std::string}}
> * Replace {{m_fieldname}} type with {{std::unordered_map<std::string,
> int32_t>}}
> * Add vector for index to field name lookup.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
