[
https://issues.apache.org/jira/browse/GEODE-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086460#comment-16086460
]
ASF GitHub Bot commented on GEODE-3203:
---------------------------------------
GitHub user WireBaron opened a pull request:
https://github.com/apache/geode/pull/632
GEODE-3203: fixing protobuf build.gradle to respect buildRoot
Signed-off-by: Bruce Schuchardt <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WireBaron/geode feature/GEODE-3203
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #632
----
commit 9322e6dfdf3d62e14d2c2f97a83ced558333883e
Author: Brian Rowe <[email protected]>
Date: 2017-07-13T21:41:43Z
GEODE-3203: fixing protobuf build.gradle to respect buildRoot
Signed-off-by: Bruce Schuchardt <[email protected]>
----
> Closed build fails on geode-protobuf when specifying custom buildRoot
> ---------------------------------------------------------------------
>
> Key: GEODE-3203
> URL: https://issues.apache.org/jira/browse/GEODE-3203
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Brian Rowe
>
> When building gemfire with a -PbuildRoot argument after successfully building
> geode, geode-protobuf:compileJava fails with:
> {noformat}
> /private/tmp/fakebuild/closed/geode-protobuf/build/generated-src/proto/main/java/org/apache/geode/protocol/protobuf/BasicTypes.java:6:
> error: duplicate class: org.apache.geode.protocol.protobuf.BasicTypes
> public final class BasicTypes {
> ^
> /private/tmp/fakebuild/closed/geode-protobuf/build/generated-src/proto/main/java/org/apache/geode/protocol/protobuf/ClientProtocol.java:6:
> error: duplicate class: org.apache.geode.protocol.protobuf.ClientProtocol
> public final class ClientProtocol {
> ^
> /private/tmp/fakebuild/closed/geode-protobuf/build/generated-src/proto/main/java/org/apache/geode/protocol/protobuf/RegionAPI.java:6:
> error: duplicate class: org.apache.geode.protocol.protobuf.RegionAPI
> public final class RegionAPI {
> ^
> /private/tmp/fakebuild/closed/geode-protobuf/build/generated-src/proto/main/java/org/apache/geode/protocol/protobuf/ServerAPI.java:6:
> error: duplicate class: org.apache.geode.protocol.protobuf.ServerAPI
> public final class ServerAPI {
> {noformat}
> These java files are generated from the .proto files describing the new
> client/server protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
