[ 
https://issues.apache.org/jira/browse/GEODE-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090852#comment-16090852
 ] 

ASF subversion and git services commented on GEODE-2860:
--------------------------------------------------------

Commit 9e7696a64621cc05122e065e492cc5e000e96622 in geode's branch 
refs/heads/develop from [~nreich]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9e7696a ]

GEODE-2860: Refactor use of EventTracker

  * change EventTracker to an interface with two implementations
  * move as much logic out of LocalRegion down into subclasses that
    make use EventTracker
  * move and refactor static inner classes in EventTracker into own
    class files
  * migrate some of event-focused classes into a new sub package
  * add tests for existing logic from EventTracker

This closes #638


> refactor EventTracker to be on DistributedRegion instead of LocalRegion
> -----------------------------------------------------------------------
>
>                 Key: GEODE-2860
>                 URL: https://issues.apache.org/jira/browse/GEODE-2860
>             Project: Geode
>          Issue Type: Improvement
>          Components: regions
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>              Labels: storage_3
>
> Currently LocalRegion has a non-final field named "eventTracker". It is 
> initialized in a method named createEventTracker which does nothing on 
> LocalRegion but is implemented on DistributedRegion and BucketRegion to 
> initialize the eventTracker field.
> I think things would be clearer if this field was moved to DistributedRegion.
> All the code on LocalRegion that currently tests for a non-null eventTracker 
> can be changed to do nothing and overridden on DistributedRegion to use its 
> eventTracker. DistributedRegion can make this field final and always set it 
> in its constructor. Since BucketRegion extends DistributedRegion it does not 
> to do anything (it currently implements createEventTracker but that was not 
> needed since it inherits the same impl from DistributedRegion).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to