[
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093757#comment-16093757
]
ASF GitHub Bot commented on GEODE-2818:
---------------------------------------
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128363171
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
--- End diff --
I think you're right - this test does seem to do just the same things
OptionAliasParserTest does. I'll get rid of this test and update the PR -
thanks!
> add alias to any command's options that involves "group", "member", "jar"
> -------------------------------------------------------------------------
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh
> Reporter: Jinmei Liao
> Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a
> string and split it inside the command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
