[
https://issues.apache.org/jira/browse/GEODE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093819#comment-16093819
]
ASF GitHub Bot commented on GEODE-3113:
---------------------------------------
GitHub user ladyVader opened a pull request:
https://github.com/apache/geode/pull/645
GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts
* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to
checking expiration
@upthewaterspout @nabarunnag
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3113
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/645.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #645
----
commit f286244a864e3eb61bbb586b678d39e0227bd574
Author: Lynn Hughes-Godfrey <[email protected]>
Date: 2017-07-18T20:48:24Z
GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts
* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to
checking expiration
----
> CI failure: .HARQAddOperationJUnitTest.testNoExpiryOnThreadIdentifier
> ---------------------------------------------------------------------
>
> Key: GEODE-3113
> URL: https://issues.apache.org/jira/browse/GEODE-3113
> Project: Geode
> Issue Type: Bug
> Components: client queues
> Affects Versions: 1.3.0
> Reporter: Shelley Lynn Hughes-Godfrey
> Assignee: Shelley Lynn Hughes-Godfrey
>
> {noformat}
> org.apache.geode.internal.cache.ha.HARQAddOperationJUnitTest >
> testNoExpiryOnThreadIdentifier FAILED
> java.lang.AssertionError: expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.internal.cache.ha.HARQAddOperationJUnitTest.testNoExpiryOnThreadIdentifier(HARQAddOperationJUnitTest.java:295)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
