[ 
https://issues.apache.org/jira/browse/GEODE-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094206#comment-16094206
 ] 

ASF GitHub Bot commented on GEODE-3206:
---------------------------------------

GitHub user deepakddixit opened a pull request:

    https://github.com/apache/geode/pull/648

    GEODE-3206 : Corrected order of lucene search results based on score.

    * Lucene results with higher score value are more relevant than lower once.
      Used descending comparator for lucene search result based on score,
      so most relevant results will be listed first.
    
    * Added test case to verify the changed order.
    
    * Modified expected result from test case, as the order of result is
      changed to match relevancy of result searched.
    
    * Optimized imports with new style file.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [X] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to [email protected].


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode bugfix/GEODE-3206

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #648
    
----
commit 4e0e921793f535fee9827b6c77ba63194bcc0f66
Author: Deepak Dixit <[email protected]>
Date:   2017-07-18T14:07:36Z

    GEODE-3206 : Corrected order of lucene search results based on score.
    
    * Lucene results with higher score value are more relevant than lower once.
      Using descending comparator for lucene search result based on score,
      so most relevant results will be listed first.
    
    * Added test case to verify the changed order.
    
    * Modified expected result from test case, as the order of result is
      changed to match relevancy of result searched.
    
    * Optimized imports with new style file.

----


> lucene search results in gfsh are listed in reverse relevancy order
> -------------------------------------------------------------------
>
>                 Key: GEODE-3206
>                 URL: https://issues.apache.org/jira/browse/GEODE-3206
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Diane Hardman
>
> Using the lucene example in the pull request for GEODE-3202, execute one of 
> the lucene searches that returns multiple results. For example:
> search lucene --name=simpleIndex --region=example-region 
> --queryStrings="firstName:pat OR lastName:chive~" --defaultField=lastName
> The results should list employee with name 'Pat' first since it is an exact 
> match and has a higher relevancy score. Instead it lists:
>  key  |                                                      value            
>                                           | score
> ----- | 
> ---------------------------------------------------------------------------------------------------------------
>  | ----------
> 10015 | EmployeeData [firstName=Jamie, lastName=Jive, emplNumber=10015, 
> email= [email protected], salary=60000, .. | 0.14384104
> 10028 | EmployeeData [firstName=Pat, lastName=Puts, emplNumber=10028, email= 
> [email protected], salary=75000, hour.. | 0.2876821
> Note the higher relevancy score is listed second.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to