[
https://issues.apache.org/jira/browse/GEODE-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099139#comment-16099139
]
ASF GitHub Bot commented on GEODE-3290:
---------------------------------------
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/653
GEODE-3290: Removed effectively-dead classes FilterChain, et al
Removed `FilterChain`, `LocalFilterChain`, and `RemoteFilterChain`.
Minor cleanup of touched files.
Precheckin running.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-3290
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #653
----
commit 2bd128e784de07b558a5a438b1de8eea6cb9fd24
Author: Patrick Rhomberg <[email protected]>
Date: 2017-07-24T21:00:43Z
GEODE-3290: Removed effectively-dead classes FilterChain, LocalFilterChain,
and RemoteFilterChain.
----
> Remove Dead Classes: FilterChain, LocalFilterChain, RemoteFilterChain
> ---------------------------------------------------------------------
>
> Key: GEODE-3290
> URL: https://issues.apache.org/jira/browse/GEODE-3290
> Project: Geode
> Issue Type: Improvement
> Components: general
> Reporter: Patrick Rhomberg
>
> `FilterChain` and its two extensions `LocalFilterChain` and
> `RemoteFilterChain` are long-dead classes whose methods are one-line boolean
> returns. The invocation of these methods is misleading, resulting a multiple
> code segments that are unreachable.
> These classes should be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
